Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix problem with Nexus getting stuck while running with too little memory #4189

Merged

Conversation

TonyWildish-BH
Copy link
Contributor

Attempts to resolve #4074

What is being addressed

The current Nexus VM is too small, and nexus doesn't get enough memory to run properly. This causes it to wedge frequently.

How is this addressed

  • Nexus VM changed from Standard_B2s to Standard_B8ms
  • Nexus deployment script updated to look how much memory the system has in total, and explicitly configure the Java VM memory based on that
  • bump version to 3.1.2

@github-actions github-actions bot added the external PR from an external contributor label Dec 11, 2024
@TonyWildish-BH
Copy link
Contributor Author

TonyWildish-BH commented Dec 11, 2024 via email

@tim-p-allen
Copy link
Collaborator

Thanks @TonyWildish will have a look. Any chance you can add a line to the CHANGELOG.md?

@TonyWildish-BH
Copy link
Contributor Author

Thanks @TonyWildish will have a look. Any chance you can add a line to the CHANGELOG.md?

done...

@marrobi
Copy link
Member

marrobi commented Dec 12, 2024

Just noting this before review, had an issue with a nexus instance due to:

2024-12-05 02:03:43,913+0000 WARN  [nexus housekeeper] *SYSTEM com.zaxxer.hikari.pool.HikariPool - nexus - Thread starvation or clock leap detected (housekeeper delta=9m1s359ms111?s287ns).

I wonder if we should avoid the B series.

@marrobi
Copy link
Member

marrobi commented Dec 12, 2024

I think a D2v3 is likely to resolve the issue.

Also worth comparing price of Standard_B8ms and D8v3.

Will try have a look later.

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, if we can address the comments, good from my perspective. Thank you for the contribution, and congrats with the go live.

@marrobi
Copy link
Member

marrobi commented Dec 13, 2024

I've had another one of these die today, not sure if the nexus container is behaving differently due to an update. @TonyWildish-BH let me know your thoughts on the changes, but keen to get this in, then follow with an option to select VM size. Thanks.

Copy link

github-actions bot commented Dec 13, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 6be2a7e.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tim-p-allen
Copy link
Collaborator

@TonyWildish Can you resolve the conflicts, then we can get this merged in.

@tim-p-allen
Copy link
Collaborator

tim-p-allen commented Dec 18, 2024

changes not covered in tests

@tim-p-allen
Copy link
Collaborator

/test-force-approve

Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 6be2a7e)

(in response to this comment from @tim-allen-ck)

@tim-p-allen tim-p-allen enabled auto-merge (squash) December 18, 2024 10:52
@tim-p-allen tim-p-allen merged commit 5bccd99 into microsoft:main Dec 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nexus VM runs out of RAM
5 participants